8000 fix: update `DeleteWorkspaceOptions` to pick properties correctly by Parkreiner · Pull Request #13423 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: update DeleteWorkspaceOptions to pick properties correctly #13423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2024
Merged

fix: update DeleteWorkspaceOptions to pick properties correctly #13423

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
620227a
fix: update typo
Parkreiner May 31, 2024
6da4072
fix: update typo in call site
Parkreiner May 31, 2024
acc6631
fix: update type for deleteWorkspace mock
Parkreiner May 31, 2024
46ca48c
fix: update one more type mismatch
Parkreiner May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update type for deleteWorkspace mock
  • Loading branch information
@Parkreiner
Parkreiner committed May 31, 2024
commit acc6631f29ede4854584c26a33c184642f7ed89c
4 changes: 3 additions & 1 deletion site/src/pages/WorkspacePage/WorkspacePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,9 @@ describe("WorkspacePage", () => {
});
await user.click(confirmButton);
// arguments are workspace.name, log level (undefined), and orphan
expect(deleteWorkspaceMock).toBeCalledWith(MockFailedWorkspace.id, {
expect(deleteWorkspaceMock).toBeCalledWith<
[string, apiModule.DeleteWorkspaceOptions]
>(MockFailedWorkspace.id, {
log_level: undefined,
orphan: true,
});
Expand Down
Loading
0