add unit tests for site & user permission attempt

coder · Emyrk · May 29, 2024 · May 23, 2024 · May 23, 2024 · May 24, 2024
commit 816f97ca7f04598441663c232a2eecef8919355a
diff --git a/enterprise/coderd/roles_test.go b/enterprise/coderd/roles_test.go
@@ -230,4 +230,47 @@ func TestCustomOrganizationRole(t *testing.T) {
 		_, err := owner.PatchOrganizationRole(ctx, first.OrganizationID, templateAdminCustom(uuid.New()))
 		require.ErrorContains(t, err, "does not match")
 	})
+
+	// Attempt to add site & user permissions, which is not allowed
+	t.Run("ExcessPermissions", func(t *testing.T) {
+		t.Parallel()
+		dv := coderdtest.DeploymentValues(t)
+		dv.Experiments = []string{string(codersdk.ExperimentCustomRoles)}
+		owner, first := coderdenttest.New(t, &coderdenttest.Options{
+			Options: &coderdtest.Options{
+				DeploymentValues: dv,
+			},
+			LicenseOptions: &coderdenttest.LicenseOptions{
+				Features: license.Features{
+					codersdk.FeatureCustomRoles: 1,
+				},
+			},
+		})
+
+		ctx := testutil.Context(t, testutil.WaitMedium)
+
+		siteRole := templateAdminCustom(first.OrganizationID)
+		siteRole.SitePermissions = []codersdk.Permission{
+			{
+				ResourceType: codersdk.ResourceWorkspace,
+				Action:       codersdk.ActionRead,
+			},
+		}
+
+		//nolint:gocritic // owner is required for this
+		_, err := owner.PatchOrganizationRole(ctx, first.OrganizationID, siteRole)
+		require.ErrorContains(t, err, "site wide permissions")
+
+		userRole := templateAdminCustom(first.OrganizationID)
+		userRole.UserPermissions = []codersdk.Permission{
+			{
+				ResourceType: codersdk.ResourceWorkspace,
+				Action:       codersdk.ActionRead,
+			},
+		}
+
+		//nolint:gocritic // owner is required for this
+		_, err = owner.PatchOrganizationRole(ctx, first.OrganizationID, userRole)
+		require.ErrorContains(t, err, "not allowed to assign user permissions")
+	})
 }