8000 fix: force logs to flush on close in peer.(*Conn) by coadler · Pull Request #1268 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: force logs to flush on close in peer.(*Conn) #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2022
Merged

fix: force logs to flush on close in peer.(*Conn) #1268

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8875b2f
fix: force logs to flush on close in peer.(*Conn)
coadler May 3, 2022
f38c771
fixup! fix: force logs to flush on close in peer.(*Conn)
coadler May 3, 2022
4e9dab4
fixup! fix: force logs to flush on close in peer.(*Conn)
coadler May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fix: force logs to flush on close in peer.(*Conn)
  • Loading branch information
@coadler
coadler committed May 3, 2022
commit f38c771c84c4d04d450392ab5f88037c9ae670e7
4 changes: 0 additions & 4 deletions peer/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,6 @@ type Conn struct {
}

func (c *Conn) logger() slog.Logger {
// The logger gets swapped
c.closeMutex.RLock()
defer c.closeMutex.RUnlock()

log, valid := c.loggerValue.Load().(slog.Logger)
if !valid {
return slog.Logger{}
Expand Down
0