8000 fix: rewrite url to agent ip in single tailnet by coadler · Pull Request #11810 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: rewrite url to agent ip in single tailnet #11810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix: rewrite url to agent ip in single tailnet #11810

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f766129
fix: rewrite url to agent ip in single tailnet
coadler Jan 24, 2024
698e697
add integration test
coadler Feb 1, 2024
682467e
add comment on idle conn tuning
coadler Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment on idle conn tuning
  • Loading branch information
@coadler
coadler committed Feb 1, 2024
commit 682467e42177eaa8a5c1b68ec9ba1c342bfdc6f7
8 changes: 7 additions & 1 deletion coderd/tailnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,14 @@ func NewServerTailnet(
transport: tailnetTransport.Clone(),
}
tn.transport.DialContext = tn.dialContext
tn.transport.MaxIdleConnsPerHost = 10
// These options are mostly just picked at random, and they can likely be
// fine tuned further. Generally, users are running applications in dev mode
// which can generate hundreds of requests per page load, so we increased
// MaxIdleConnsPerHost from 2 to 6 and removed the limit of total idle
// conns.
tn.transport.MaxIdleConnsPerHost = 6
tn.transport.MaxIdleConns = 0
tn.transport.IdleConnTimeout = 10 * time.Minute
// We intentionally don't verify the certificate chain here.
// The connection to the workspace is already established and most
// apps are already going to be accessed over plain HTTP, this config
Expand Down
0