8000 fix: always attempt external auth refresh when fetching by Emyrk · Pull Request #11762 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: always attempt external auth refresh when fetching #11762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 25, 2024
Merged

fix: always attempt external auth refresh when fetching #11762

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3b6a39f
fix: always attempt external auth refresh when fetching
Emyrk Jan 22, 2024
5d0489b
refactor validate to check expiary
Emyrk Jan 22, 2024
778184d
linting
Emyrk Jan 23, 2024
2281db2
compile fix
Emyrk Jan 23, 2024
189c8ae
fix return
Emyrk Jan 23, 2024
531f45e
fix extra re-validate call
Emyrk Jan 24, 2024
68b8792
handle no expiry
Emyrk Jan 24, 2024
0879fd6
Fix comment
Emyrk Jan 25, 2024
3d28fe7
fix typo
Emyrk Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix comment
  • Loading branch information
@Emyrk
Emyrk committed Jan 25, 2024
commit 0879fd6614f37e7df6b04c2c675278b2f3e565c9
4 changes: 2 additions & 2 deletions coderd/workspaceagents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,8 +1623,8 @@ func TestWorkspaceAgentExternalAuthListen(t *testing.T) {
ticks <- time.Now()
}
cancel()
// We expect only 2. One from the initial "Refresh" attempt, and
// another from the first tick. Ideally this would be just one.
// We expect only 1. One from the initial "Refresh" attempt, and the
// other sshould be skipped.
// In a failed test, you will likely see 9, as the last one
// gets canceled.
require.Equal(t, 1, validateCalls, "validate calls duplicated on same token")
Expand Down
0