8000 fix: refresh all oauth links on external auth page by Emyrk · Pull Request #11604 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: refresh all oauth links on external auth page #11604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

fix: refresh all oauth links on external auth page #11604

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c37600e
chore: move some components into pages/ (#11536)
aslilac Jan 11, 2024
0ac0fab
fix: remove cancel button if user cannot cancel job (#11553)
f0ssel Jan 11, 2024
3a17b89
feat: add a character counter for fields with length limits (#11558)
aslilac Jan 11, 2024
b3a61b6
fix: publish workspace update on quota failure (#11559)
f0ssel Jan 11, 2024
bf87e35
feat(site): add docs links on health page (#11582)
johnstcn Jan 11, 2024
80de2c5
feat(site): remove experiment deployment_health_page (#11572)
johnstcn Jan 11, 2024
9d10858
feat: treat deprecation messages as markdown (#11562)
aslilac Jan 11, 2024
a074f28
fix: fix template edit overriding with flag defaults (#11564)
sreya Jan 11, 2024
46920a8
chore: handle errors in wsproxy server for cli using buildinfo (#11584)
Emyrk Jan 11, 2024
160535f
fix(coderd): correctly show warning when no provisioner daemons are r…
johnstcn Jan 12, 2024
f7149b4
fix(site): fix resource selection when workspace resources change (#1…
BrunoQuaresma Jan 12, 2024
7eeeb5f
feat: load variables from tfvars files (#11549)
mtojek Jan 12, 2024
5b99182
fix: refresh all oauth links on external auth page
Emyrk Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(coderd): correctly show warning when no provisioner daemons are r… 
…egistered (#11591)
  • Loading branch information
@johnstcn @Emyrk
johnstcn authored and Emyrk committed Jan 12, 2024
commit 160535f8b301c979a7f37ed6373c6a0c6c5f7327
2 changes: 1 addition & 1 deletion coderd/healthcheck/provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func (r *ProvisionerDaemonsReport) Run(ctx context.Context, opts *ProvisionerDae

if len(r.Items) == 0 {
r.Severity = health.SeverityError
r.Error = ptr.Ref("No active provisioner daemons found!")
r.Warnings = append(r.Warnings, health.Messagef(health.CodeProvisionerDaemonsNoProvisionerDaemons, "No active provisioner daemons found!"))
return
}
}
4 changes: 2 additions & 2 deletions coderd/healthcheck/provisioner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ func TestProvisionerDaemonReport(t *testing.T) {
currentVersion: "v1.2.3",
currentAPIMajorVersion: provisionersdk.CurrentMajor,
expectedSeverity: health.SeverityError,
expectedError: "No active provisioner daemons found!",
expectedItems: []healthcheck.ProvisionerDaemonsReportItem{},
expectedWarningCode: health.CodeProvisionerDaemonsNoProvisionerDaemons,
},
{
name: "error fetching daemons",
Expand Down Expand Up @@ -303,7 +303,7 @@ func TestProvisionerDaemonReport(t *testing.T) {
currentVersion: "v2.3.4",
currentAPIMajorVersion: provisionersdk.CurrentMajor,
expectedSeverity: health.SeverityError,
expectedError: "No active provisioner daemons found!",
expectedWarningCode: health.CodeProvisionerDaemonsNoProvisionerDaemons,
provisionerDaemons: []database.ProvisionerDaemon{fakeProvisionerDaemonStale(t, "pd-ok", "v1.2.3", "0.9", now.Add(-5*time.Minute), now)},
expectedItems: []healthcheck.ProvisionerDaemonsReportItem{},
},
Expand Down
1 change: 1 addition & 0 deletions site/src/pages/HealthPage/ProvisionerDaemonsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export const ProvisionerDaemonsPage = () => {
</Header>

<Main>
{daemons.error && <Alert severity="error">{daemons.error}</Alert>}
{daemons.warnings.map((warning) => {
return (
<Alert
Expand Down
0