8000 chore: remove duplicate validate calls on same oauth token by Emyrk · Pull Request #11598 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

chore: remove duplicate validate calls on same oauth token #11598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2024
Merged

chore: remove duplicate validate calls on same oauth token #11598

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1cfb91
chore: remove duplicate validate calls on same oauth token
Emyrk Jan 12, 2024
842e602
linting
Emyrk Jan 12, 2024
489a9b8
wording
Emyrk Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting
  • Loading branch information
@Emyrk
Emyrk committed Jan 12, 2024
commit 842e6021310a8e643bea831d11612af41b929e09
2 changes: 2 additions & 0 deletions coderd/workspaceagents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,6 +1554,8 @@ func TestWorkspaceAgentExternalAuthListen(t *testing.T) {
// Note that an expired oauth token is already skipped, so this really
// only covers the case of a revoked token.
t.Run("ValidateURLSpam", func(t *testing.T) {
t.Parallel()

const providerID = "fake-idp"

// Count all the times we call validate
Expand Down
0