8000 fix(coderd/healthcheck): add daemon-specific warnings to healthcheck output by johnstcn · Pull Request #11490 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix(coderd/healthcheck): add daemon-specific warnings to healthcheck output #11490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2024
Merged

fix(coderd/healthcheck): add daemon-specific warnings to healthcheck output #11490

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
377ca04
fix(coderd/healthcheck): scope warnings in ProvisionerDaemonsReport
johnstcn Jan 8, 2024
b0977b8
fix msg
johnstcn Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix msg
  • Loading branch information
@johnstcn
johnstcn committed Jan 8, 2024
commit b0977b84bf0e89e6ec8a73ab5a13f131d7efa4f9
2 changes: 1 addition & 1 deletion coderd/healthcheck/provisioner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func (r *ProvisionerDaemonsReport) Run(ctx context.Context, opts *ProvisionerDae
if r.Severity.Value() < health.SeverityError.Value() {
r.Severity = health.SeverityError
}
r.Warnings = append(r.Warnings, health.Messagef(health.CodeUnknown, "Some provisioner daemons reports invalid API version information"))
r.Warnings = append(r.Warnings, health.Messagef(health.CodeUnknown, "Some provisioner daemons report invalid API version information."))
it.Warnings = append(it.Warnings, health.Messagef(health.CodeUnknown, "Invalid API version: %s", err.Error())) // contains version string
} else if maj != opts.CurrentAPIMajorVersion {
if r.Severity.Value() < health.SeverityWarning.Value() {
Expand Down
0