10000 feat!: move workspace renames behind flag, disable by default by f0ssel · Pull Request #11189 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat!: move workspace renames behind flag, disable by default #11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Dec 15, 2023
Merged

feat!: move workspace renames behind flag, disable by default #11189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
289db73
feat: Add flag to allow workspace renames
f0ssel Dec 13, 2023
b1673fe
make gen
f0ssel Dec 13, 2023
49e6be6
add tests
f0ssel Dec 13, 2023
9faf9e3
edit description
f0ssel Dec 13, 2023
ca5cbe0
make gen
f0ssel Dec 13, 2023
ebe9180
correct api response
f0ssel Dec 13, 2023
f572f9d
frontend form
f0ssel Dec 13, 2023
dd629ae
make fmt
f0ssel Dec 13, 2023
5fd24a7
fix test
f0ssel Dec 13, 2023
b84bca2
update golden
f0ssel Dec 13, 2023
d811238
fix cli test
f0ssel Dec 13, 2023
691b8c5
fix watcher test
f0ssel Dec 13, 2023
4da4093
address pr comments
f0ssel Dec 14, 2023
f9bd7c2
remove time component
f0ssel Dec 15, 2023
db34075
make gen
f0ssel Dec 15, 2023
7856e82
properly disable form
f0ssel Dec 15, 2023
6a3a9e7
add helper text
f0ssel Dec 15, 2023
8f96b3d
make fmt
f0ssel Dec 15, 2023
aef6814
correct submit logic
f0ssel Dec 15, 2023
a642086
fix mistake
f0ssel Dec 15, 2023
4f68fc5
pr comment wording
f0ssel Dec 15, 2023
57a5588
update golden
f0ssel Dec 15, 2023
b8c12f8
frontend cleanup
f0ssel Dec 15, 2023
f69ccda
make fmt
f0ssel Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
frontend form
  • Loading branch information
@f0ssel
f0ssel committed Dec 15, 2023
commit f572f9dfe9e65f0692ee8ee9640ad3635d33f038
4 changes: 2 additions & 2 deletions site/src/pages/WorkspaceSettingsPage/WorkspaceSettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const WorkspaceSettingsForm: FC<{
<FormFields>
<TextField
{...getFieldHelpers("name")}
disabled={form.isSubmitting}
disabled={!workspace.allow_renames || form.isSubmitting}
onChange={onChangeTrimmed(form)}
autoFocus
fullWidth
Expand Down Expand Up @@ -106,7 +106,7 @@ export const WorkspaceSettingsForm: FC<{
</FormFields>
</FormSection>
)}
<FormFooter onCancel={onCancel} isLoading={form.isSubmitting} />
<FormFooter onCancel={onCancel} isLoading={form.isSubmitting} submitDisabled={!templatePoliciesEnabled && !workspace.allow_renames}/>
</HorizontalForm>
);
};
1 change: 1 addition & 0 deletions site/src/testHelpers/entities.ts
View file
Open in desktop 679A
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,7 @@ export const MockWorkspace: TypesGen.Workspace = {
failing_agents: [],
},
automatic_updates: "never",
allow_renames: false,
};

export const MockStoppedWorkspace: TypesGen.Workspace = {
Expand Down
0