8000 fix: stop updating agent stats from deleted workspaces by f0ssel · Pull Request #11026 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

fix: stop updating agent stats from deleted workspaces #11026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 7, 2023
+74 −6
Merged

fix: stop updating agent stats from deleted workspaces #11026

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4150a99
fix: prevent deleted workspaces from updating agent stats
f0ssel Dec 4, 2023
7721b2d
remove comment
f0ssel Dec 4, 2023
f1d3279
lint
f0ssel Dec 4, 2023
f3b7b9a
use query over route logic
f0ssel Dec 7, 2023
0e36f03
Apply suggestions from code review
f0ssel Dec 7, 2023
44deada
fix
f0ssel Dec 7, 2023
dd08f2f
fix AuthzUserSubject to include member and org member role
Emyrk Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@f0ssel
f0ssel committed Dec 4, 2023
commit 7721b2dd8918d23e9f2d098d9dcde2e3d631d0a5
5 changes: 1 addition & 4 deletions coderd/workspaceagents_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,10 +892,7 @@ func TestWorkspaceAgentReportStats(t *testing.T) {
agentClient.SetSessionToken(r.AgentToken)

_, err := agentClient.PostStats(context.Background(), &agentsdk.Stats{
ConnectionsByProto: map[string]int64{"TCP": 1},
// Set connection count to 1 but all session counts to zero to
// assert we aren't updating last_used_at for a connections that may
// be spawned passively by the dashboard.
ConnectionsByProto: map[string]int64{"TCP": 1},
ConnectionCount: 1,
RxPackets: 1,
RxBytes: 1,
Expand Down
0