fix: redirect to new url after template name update #10926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
requested changes
Nov 28, 2023
| }); | ||
| await expect(page).toHaveURL(`/templates/${templateName}/settings`); | ||
|
|
||
| for (const [key, value] of Object.entries(templateSettingValues)) { |
There was a problem hiding this comment.
There's nothing wrong with the code right now, but there is a risk in the future from runtime/compile-time mismatches:
const myObj = {
name: "whoops",
obviouslyWrongValue: true
};
// No error
updateTemplateSettings(page, templateName, myObj);Just to be on the safe side, and because this is a general test helper, I'm wondering if there should be a runtime check on the key to make sure that you're only ever processing name/display_name/description
There was a problem hiding this comment.
Edited the message because I didn't like the way my tone sounded. Sorry about that
Parkreiner
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10634