8000 feat(site): add stop and start batch actions by BrunoQuaresma · Pull Request #10565 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat(site): add stop and start batch actions #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 8, 2023
Merged

feat(site): add stop and start batch actions #10565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7038c8b
Refactor MoreMnu to be more flexible
BrunoQuaresma Nov 7, 2023
07c1d29
Update menus to use the new way
BrunoQuaresma Nov 7, 2023
8994d1b
Add base
BrunoQuaresma Nov 7, 2023
dd32703
Fix wrong deps
BrunoQuaresma Nov 7, 2023
894629d
Add bulk actions
BrunoQuaresma Nov 7, 2023
85696d3
Extract batch logic into a hook
BrunoQuaresma Nov 7, 2023
59ed10f
Fix missed step to close delete all modal
BrunoQuaresma Nov 7, 2023
eebbdd4
Fix tests
BrunoQuaresma Nov 7, 2023
78aa58f
Fix fmt
BrunoQuaresma Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10000
Prev Previous commit
Next Next commit
Fix missed step to close delete all modal
  • Loading branch information
@BrunoQuaresma
BrunoQuaresma committed Nov 7, 2023
commit 59ed10f753a735e5b38247d1d553c69d88c77284
7 changes: 4 additions & 3 deletions site/src/pages/WorkspacesPage/BatchActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export const BatchDeleteConfirmation = (
const { checkedWorkspaces, open, onClose, onConfirm, isLoading } = props;
const [confirmation, setConfirmation] = useState({ value: "", error: false });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What values is value expected to have right now? So far, it looks like "" or DELETE?
I'm wondering if value could have its own type, if we're only going to be supporting a discrete set of operations

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea but it does not work well for "dynamic" values since it can be whatever the user types and not only the "final" result. Makes sense? The values can be "D", "DE", "DEL", "DELE" or anything like "OTHER".


const confirmDeletion = async () => {
const confirmDeletion = () => {
setConfirmation((c) => ({ ...c, error: false }));

if (confirmation.value !== "DELETE") {
Expand Down Expand Up @@ -100,7 +100,7 @@ export const BatchDeleteConfirmation = (
<form
onSubmit={async (e) => {
e.preventDefault();
await confirmDeletion();
confirmDeletion();
}}
>
<Box>
Expand Down Expand Up @@ -129,7 +129,8 @@ export const BatchDeleteConfirmation = (
placeholder="Type DELETE to confirm"
sx={{ mt: 2 }}
onChange={(e) => {
setConfirmation((c) => ({ ...c, value: e.currentTarget.value 8000 }));
const value = e.currentTarget?.value;
setConfirmation((c) => ({ ...c, value }));
}}
error={confirmation.error}
helperText={confirmation.error && "Please type DELETE to confirm"}
Expand Down
5 changes: 4 additions & 1 deletion site/src/pages/WorkspacesPage/WorkspacesPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ const WorkspacesPage: FC = () => {
isLoading={batchActions.isLoading}
checkedWorkspaces={checkedWorkspaces}
open={isConfirmingDeleteAll}
onConfirm={() => batchActions.deleteAll(checkedWorkspaces)}
onConfirm={async () => {
await batchActions.deleteAll(checkedWorkspaces);
setIsConfirmingDeleteAll(false);
}}
onClose={() => {
setIsConfirmingDeleteAll(false);
}}
Expand Down
0