feat: expose app insights as Prometheus metrics #10346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not stale yet, I was on PTO. |
mafredri
approved these changes
Nov 7, 2023
| -- Subtract one minute because the series only contains the start time. | ||
| AND s.start_time < (@end_time::timestamptz) - '1 minute'::interval | ||
| GROUP BY s.start_time, w.template_id, was.user_id, was.agent_id, was.slug_or_port, wa.display_name, wa.slug | ||
| ) |
There was a problem hiding this comment.
Would it make sense to keep this part as similar as GetTemplateAppInsights as possible, to reduce the maintenance burden/overhead of figuring out if a change should affect both? AFAICT the only change is removal of access_method, but if we drop that there's also other simplifications we could do. Similarly, I don't think we gain much by dropping it.
There was a problem hiding this comment.
The reasons why I decided to "fork" the query are:
- Pulling unused columns from the database - I guess we can pull more as these fields do not carry heavy data.
AND CASE WHEN COALESCE(array_length(@template_ids::uuid[], 1), 0) > 0 THEN w.template_id = ANY(@template_ids::uuid[]) ELSE TRUE ENDinGetTemplateAppInsightswill be always false, so I just dropped it.- No need to perform
array_aggin the last SELECT operation.
I would rather keep the forked query, but I could add a comment to justify above differences? Unless you are aware of a smart trick which isn't a FUNCTION.
EDIT:
I guess we can improve this in a follow-up 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #9983
This PR adds support for exposing app insights metrics via the Prometheus endpoint.