8000 feat: add `external-auth` cli by kylecarbs · Pull Request #10052 · coder/coder · GitHub
[go: up one dir, main page]
Skip to content

feat: add external-auth cli #10052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 9, 2023
Merged

feat: add external-auth cli #10052

merged 10 commits into from
Oct 9, 2023

Conversation

kylecarbs
Copy link
Member
@kylecarbs kylecarbs commented Oct 4, 2023 •
edited
Loading

This will allow us to enable scripting around external authentication. I assume we'll add more functionality to the external-auth subcommand, which is why access-token is nested.

data "coder_external_auth" "slack" {
  id = "slack"
}

resource "coder_script" "notify-slack" {
  # Write a file to the $PATH that executes `coder external-auth access-token slack` at the
  # beginning to check for permissions, awaits for a command to execute and notifies the user
  # via a Slack message!
}

@kylecarbs kylecarbs self-assigned this Oct 4, 2023
@Shocktrooper
Copy link

One thing I noticed with the external auth is since open source is limited to 1 external auth provider it makes it hard to test out a git provider + an oidc application together to see if they work for testing templates(our dev environment uses Open Source). Would it be possible to bump the open source limit to 1 git provider + 1 alternate provider configuration that is not a git based provider?

@kylecarbs
Copy link
Member Author

@Shocktrooper could you share more about the specific use-case you're solving for? I'm open to the idea, I just wanna make sure it's not something that could be discovered in a free trial.

@kylecarbs kylecarbs marked this pull request as ready for review October 9, 2023 19:35
@kylecarbs kylecarbs requested review from coadler and bpmct October 9, 2023 19:37
@kylecarbs kylecarbs mentioned this pull request Oct 9, 2023
Merged
coadler
coadler approved these changes Oct 9, 2023
View reviewed changes
cli/externalauth.go Outdated
echo "Authenticated with GitHub"
else
echo "Please authenticate with GitHub:"
coder external-auth url github
Copy link
8000
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a external-auth url cmd.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@kylecarbs kylecarbs enabled auto-merge (squash) October 9, 2023 22:16
@kylecarbs kylecarbs merged commit 35538e1 into main Oct 9, 2023
@kylecarbs kylecarbs deleted the gitauthcli branch October 9, 2023 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @Shocktrooper @coadler
0