8000 fix: add handle for resolveExternalUri by jsjoeio · Pull Request #5624 · coder/code-server · GitHub
[go: up one dir, main page]

Skip to content

fix: add handle for resolveExternalUri #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 14, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup!: remove e2e test, update patch notes
  • Loading branch information
jsjoeio committed Oct 13, 2022
commit 64984bdabd9858d4a7d148e203c2c7fa00a6037c
9 changes: 9 additions & 0 deletions patches/proxy-uri.diff
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ extensions, use --extensions-dir, or symlink it).

This has e2e tests.

For the `asExternalUri` changes, you'll need to test manually by:
1. running code-server with the test extension
2. Command Palette > code-server: asExternalUri test
3. input a url like http://localhost:3000
4. it should show a notification and show output as <code-server>/proxy/3000

Do the same thing but set `VSCODE_PROXY_URI: "https://{{port}}-main-workspace-name-user-name.coder.com"`
and the output should replace `{{port}}` with port used in input url.

Index: code-server/lib/vscode/src/vs/base/common/product.ts
===================================================================
--- code-server.orig/lib/vscode/src/vs/base/common/product.ts
Expand Down
48 changes: 0 additions & 48 deletions test/e2e/asExternalUri.test.ts

This file was deleted.

0