8000 Add port in use message by nol166 · Pull Request #418 · coder/code-server · GitHub
[go: up one dir, main page]
Skip to content

Add port in use message #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 3, 2019
Merged

Add port in use message #418

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2a004e9
Add clear error message if port is in use
Apr 3, 2019
b618f1d
Add bold function for text/numbers
Apr 3, 2019
8bbdb29
remove unused dependency:
Apr 3, 2019
2a672d2
remove unused line break
Apr 3, 2019
813afd3
Change logger message
Apr 3, 2019
19befda
Use NodeJS.ErrnoException type
Apr 3, 2019
10a2e9a
Add back check for error code
Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change logger message
  • Loading branch information
John McCambridge committed Apr 3, 2019
commit 813afd38285d73ab279e10e55bb8f7f8118e7344
2 changes: 1 addition & 1 deletion packages/server/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ const bold = (text: string | number): string | number => {
});
app.wss.on("error", (err: {code: string}) => {
if (err.code === "EADDRINUSE") {
logger.error(`Port ${bold(options.port)} is in use. Please free up port ${options.port} or specify another with the -p flag`);
logger.error(`Port ${bold(options.port)} is in use. Please free up port ${options.port} or specify a different port with the -p flag`);
process.exit(1);
}
});
Expand Down
1 change: 0 additions & 1 deletion packages/server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ export const createApp = async (options: CreateAppOptions): Promise<{

handleTunnel(ws, port);
} catch (ex) {
console.log("test")
ws.close(TunnelCloseCode.Error, ex.toString());
}

Expand Down
0