cli: add --home flag to customize "Go Home" button #2435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit separation is really on point @jsjoeio |
|
If you go here, you can see where your changes (@nhooyr) were reverted: 0e7f504#diff-9e295724ddcc33de1e1e16290c98d43f43e5ce542612dd015d982853be82493cL3869-L3872 |
|
Documenting: @nhooyr hopped on a Zoom call with me. For whatever reason, it worked when he did it and pushed his commit 🤷♂️ |
code-asher
reviewed
Dec 14, 2020
f8c00e9 to
f941bec
Compare
f941bec to
71abff7
Compare
|
For anyone who comes here later, the reason I had to force-push was because I had to create a GPG key to sign and verify my commits. The only way to sign old commits was to rebase and force-push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new cli flag
--homewhich allows the user to customize the "Go Home" button seen in the application menu.Changes
--homeas a valid CLI flag to configure link for "Go Home" buttonScreenshots
Checklist
Related
Fixes #2328