Revert dependencies to pre-Dependabot #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts all dependencies to how they were scaffolded, before Dependabot started making updates.
21c392b to
91e6f27
Compare
91e6f27 to
a23e90d
Compare
Since the plugins, app, and backend share a lockfile, it seems we can get some odd issues when we update dependencies that are not caught until the next time a plugin is tested. In particular, this happened with Dependabot, and although we were updating the package.json as well to make sure affected plugins were tested I think the issue comes with updating dependencies of dependencies not directly listed in the package.json.
Parkreiner
reviewed
Mar 28, 2024
Parkreiner
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts each package.json and the main yarn.lock file to how they were scaffolded, before Dependabot started making updates.
Edit: I bumped the
@testing-library/*dependencies (since without that we get an error aboutrenderHook) then ranyarn installagain. This should also cover lockfile changes we made manually in between Dependabot updates that could not be cleanly reverted (there was only one that I saw).So, this is not strictly pre-Dependabot anymore, but should be the same result as if we had never used it.
Edit 2: I modified CI to test all plugins whenever the lockfile changes. So we can probably add Dependabot back if we want, although I would prefer we use something that batches updates into a single PR every week or so because it was pretty noisy and tedious. I wonder also if we want to exclude Backstage dependencies so we can handle those manually.