8000 Model validation test fixture updates by sinha108 · Pull Request #134 · codellm-devkit/python-sdk · GitHub
[go: up one dir, main page]

Skip to content

Model validation test fixture updates #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025

Conversation

sinha108
Copy link
Collaborator

Motivation and Context

This PR contains the following updates and fixes:

  • Fix in the validation code to add field missing JCallable fields and remove spurious field
  • Update the analysis json fixture used in test cases and remove unused analysis json fixtures
  • Update test fixture setup to use codeanalyzer jar from the source directory instead of test resources
  • Remove dangling codeanalyzer jars from test resources

How Has This Been Tested?

Tested by running all existing Java analysis tests (some of which were failing previously)

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Test resources cleanup

Checklist

  • I have read the Codellm-Devkit Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

sinha108 added 4 commits June 9, 2025 14:32
Signed-off-by: Saurabh Sinha <sinha108@gmail.com>
Signed-off-by: Saurabh Sinha <sinha108@gmail.com>
Signed-off-by: Saurabh Sinha <sinha108@gmail.com>
…/java/codeanalyzer/jar

instead of the test resources directory; removed dangling codeanalyzer jars from test resources

Signed-off-by: Saurabh Sinha <sinha108@gmail.com>
@sinha108 sinha108 requested a review from rahlk June 11, 2025 14:12
@rahlk rahlk merged commit f036632 into main Jun 11, 2025
@rahlk rahlk deleted the model-validation-test-fixture-updates branch June 11, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0