E538 translate lang [id] by kikuKeii · Pull Request #912 · codeigniter4/shield · GitHub
[go: up one dir, main page]
Skip to content

translate lang [id]#912

Closed
kikuKeii wants to merge 1 commit intocodeigniter4:developfrom
Closed

translate lang [id]#912
kikuKeii wants to merge 1 commit intocodeigniter4:developfrom
kikuKeii:feature/translation-indonesian

Conversation

@kikuKeii
Copy link
Contributor
@kikuKeii kikuKeii commented Oct 17, 2023 •
edited by kenjis
Loading

Description
I have changed src\Language\id\Auth.php. Because there are sentences that have not been translated

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the lang Languages file label Oct 17, 2023
@kenjis
Copy link
Member
kenjis commented Oct 17, 2023

Hi, the following test failed. Please fix.

1) Tests\Language\IndonesianTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "id" ('id')
Failed asserting that the translated language key "Auth.token" in "id" locale differs from the original keys in the main repository.
Failed asserting that an array is empty.

/home/runner/work/shield/shield/tests/Language/AbstractTranslationTestCase.php:260

@kenjis
Copy link
Member
kenjis commented Oct 17, 2023

You must GPG-sign your work, certifying that you either wrote the work or otherwise have the right to pass it on to an open-source project. See Developer's Certificate of Origin.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing

@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Oct 17, 2023
@kenjis
Copy link
Member
kenjis commented Oct 17, 2023

The signing is Unverified.
Screenshot 2023-10-17 19 33 27
Screenshot 2023-10-17 19 33 37

@datamweb
Copy link
Collaborator
datamweb commented Oct 17, 2023

@kikuKeii See #672 (comment)

@kikuKeii
Copy link
Contributor Author
kikuKeii commented Oct 17, 2023

sorry, I will make a new pull request after I setup GPG-sign on my account

@kikuKeii kikuKeii closed this Oct 17, 2023
@kikuKeii kikuKeii mentioned this pull request Oct 17, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

GPG-Signing needed Pull requests that need GPG-Signing lang Languages file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kikuKeii @kenjis @datamweb
0