fix: UserModel::assignIdentities() always produces a DB query#806
Merged
datamweb merged 3 commits intocodeigniter4:developfrom Sep 5, 2023
Merged
fix: UserModel::assignIdentities() always produces a DB query#806datamweb merged 3 commits intocodeigniter4:developfrom
datamweb merged 3 commits intocodeigniter4:developfrom
Conversation
datamweb
approved these changes
Aug 29, 2023
kenjis
reviewed
Sep 5, 2023
Member
|
Am I correct in assuming that this PR prevents queries to retrieve unnecessary Identities from being executed? |
Member
|
The code looks good. |
Co-authored-by: kenjis <kenji.uui@gmail.com>
Member
Author
There was never a problem with the incorrect result per se. The problem here was that we were producing n+1 queries for code like this: $users = model(UserModel::class)->withIdentities()->findAll();
foreach ($users as $user) {
$user->email;
}That would be just fine, but since we use |
kenjis
approved these changes
Sep 5, 2023
Collaborator
|
Thanks All! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
UserModel- when we usewithIdentities()method the query is produced properly.The problem occurs in the
assignIdentities()method, when we're trying to assign identities to the users.We're working with the
Userentity, and there is a line:It will call
getIdentities()method which will produce a query to the DB, since there are no identities assigned yet.This PR solves this problem.