8000 refactor: use ::class keyword in config() by kenjis · Pull Request #748 · codeigniter4/shield · GitHub
[go: up one dir, main page]

Skip to content

refactor: use ::class keyword in config()#748

Merged
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:refactor-use-class-in-config
May 22, 2023
Merged

refactor: use ::class keyword in config()#748
kenjis merged 1 commit intocodeigniter4:developfrom
kenjis:refactor-use-class-in-config

Conversation

@kenjis
Copy link
Member
@kenjis kenjis commented May 19, 2023

No description provided.

@datamweb datamweb added the refactor Pull requests that refactor code label May 20, 2023
@datamweb
Copy link
Collaborator
datamweb commented May 22, 2023

Sorry @kenjis , I didn't approve this PR to avoid new trouble(resolve conflicts) for contributor #744 .
please rebase.

@kenjis kenjis force-pushed the refactor-use-class-in-config branch from d3b5bf9 to bee838a Compare May 22, 2023 01:34
@kenjis
Copy link
Member Author
kenjis commented May 22, 2023

Rebased.

Copy link
Collaborator
@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kenjis kenjis merged commit 736a88f into codeigniter4:develop May 22, 2023
@kenjis kenjis deleted the refactor-use-class-in-config branch May 22, 2023 02:17
@kenjis kenjis restored the refactor-use-class-in-config branch July 5, 2023 11:13
@kenjis kenjis deleted the refactor-use-class-in-config branch August 24, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0