8000 feat: add login link to magic link form view by GeorgKott · Pull Request #730 · codeigniter4/shield · GitHub
[go: up one dir, main page]
Skip to content

feat: add login link to magic link form view#730

Merged
kenjis merged 2 commits intocodeigniter4:developfrom
GeorgKott:add_login_link_on_magiclinkform_view
May 17, 2023
Merged

feat: add login link to magic link form view#730
kenjis merged 2 commits intocodeigniter4:developfrom
GeorgKott:add_login_link_on_magiclinkform_view

Conversation

@GeorgKott
Copy link
Contributor
@GeorgKott GeorgKott commented May 7, 2023 •
edited by kenjis
Loading

Supersedes #394
Closes #299

Thank you

@datamweb datamweb added the enhancement New feature or request label May 7, 2023
datamweb
datamweb requested changes May 7, 2023
View reviewed changes
Copy link
Collaborator
@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgKott thank you for PR.
This issue has already been implemented in PR #394, only the test has not been added.

Can you do the same as PR #394 with the test?

And I edited your comment, why? you can read here.

@GeorgKott
Copy link
Contributor Author
GeorgKott commented May 7, 2023

I did the same as PR #394, exept changing "backToLogin" key to "usePassword". And add simple test.
Thank you for edited comment

@datamweb
Copy link
Collaborator
datamweb commented May 7, 2023

exept changing "backToLogin" key to "usePassword"

Yes, I mean using backToLogin. It seems to help the readability of the code. so please use backToLogin.

NOTE:
Make your commit messages meaningful.
Commit messages are important. They communicate the intent of a specific change, concisely. They make it easier to review code, and to find out why a change was made if the code history is examined later.

The audience for your commit messages will be the codebase maintainers, any code reviewers, and debuggers trying to figure out when a bug might have been introduced.

There are some references for writing good commit messages:
Git Best Practices — AFTER Technique - DZone DevOps
Semantic Commit Messages
Conventional Commits

more info see here.

@GeorgKott
Copy link
Contributor Author
GeorgKott commented May 8, 2023

exept changing "backToLogin" key to "usePassword"

Yes, I mean using backToLogin. It seems to help the readability of the code. so please use backToLogin.

NOTE: Make your commit messages meaningful. Commit messages are important. They communicate the intent of a specific change, concisely. They make it easier to review code, and to find out why a change was made if the code history is examined later.

The audience for your commit messages will be the codebase maintainers, any code reviewers, and debuggers trying to figure out when a bug might have been introduced.

There are some references for writing good commit messages: Git Best Practices — AFTER Technique - DZone DevOps Semantic Commit Messages Conventional Commits

more info see here.

Thank you for links! I did some changes

datamweb
datamweb approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator
@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorgKott thank you!
LGTM.

@kenjis kenjis changed the title add login link to magic link form view feat: add login link to magic link form view May 17, 2023
@kenjis kenjis merged commit 2a3d67c into codeigniter4:develop May 17, 2023
@kenjis
Copy link
Member
kenjis commented May 17, 2023

@GeorgKott Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing back link on Magic Link form

3 participants

@GeorgKott @datamweb @kenjis
0