refactor: Ensure findById returns null instead of an array when ID is null#1263
Open
refactor: Ensure findById returns null instead of an array when ID is null#1263
findById returns null instead of an array when ID is null#1263Conversation
…`null` Although the phpdocs states that the ID ($id) should not be `null`, in some cases, data may be retrieved from the database where the ID is set to `null`. When `null` is passed to the `find($id)` method, instead of returning null or a User object, it returns an empty array ([]). This leads to a type mismatch with the method signature, which expects a return type of `?User`, causing the error: ``` CodeIgniter\Shield\Models\UserModel::findById(): Return value must be of type ?CodeIgniter\Shield\Entities\User, array returned ``` This change ensures that the method always adheres to the expected return type (?User), preventing unexpected runtime errors.
|
Unit Testing: So please write a unit test or update the existing tests. See unit testing for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although the phpdocs states that the ID ($id) should not be
null, in some cases, data may be retrieved from the database where the ID is set tonull.When
nullis passed to thefind($id)method, instead of returning null or a User object, it returns an empty array ([]).This leads to a type mismatch with the method signature, which expects a return type of
?User, causing the error:CodeIgniter\Shield\Models\UserModel::findById(): Return value must be of type ?CodeIgniter\Shield\Entities\User, array returned
This change ensures that the method always adheres to the expected return type (?User), preventing unexpected runtime errors.
Checklist: