8000 lang: [pl] add Polish translation by mieszkou · Pull Request #1117 · codeigniter4/shield · GitHub
[go: up one dir, main page]
Skip to content

lang: [pl] add Polish translation#1117

Merged
datamweb merged 26 commits intocodeigniter4:developfrom
mieszkou:pl-translation
May 19, 2024
Merged

lang: [pl] add Polish translation#1117
datamweb merged 26 commits intocodeigniter4:developfrom
mieszkou:pl-translation

Conversation

@mieszkou
Copy link
Contributor
@mieszkou mieszkou commented May 12, 2024

I added a Polish translation of the texts

@mieszkou mieszkou changed the title Polish translation [lang] Polish May 12, 2024
@mieszkou mieszkou changed the title [lang] Polish lang: Polish May 12, 2024
@datamweb datamweb added GPG-Signing needed Pull requests that need GPG-Signing tests needed Pull requests that need tests labels May 12, 2024
@datamweb
Copy link
Collaborator
datamweb commented May 12, 2024

Hi,
Thank you for contributing!
Please see #235 (comment)

@datamweb datamweb added the lang Languages file label May 12, 2024
@datamweb datamweb changed the title lang: Polish lang: [pl] add Polish translation May 12, 2024
michalsn
michalsn requested changes May 13, 2024
View reviewed changes
@kenjis
Copy link
Member
kenjis commented May 14, 2024

Please fix the following failure.

There was 1 failure:

1) Tests\Language\PolishTranslationTest::testAllIncludedLanguageKeysAreTranslated with data set "pl" ('pl')
Failed asserting that the translated language key "Auth.token" in "pl" locale differs from the original keys in the main repository.
Failed asserting that an array is empty.

/home/runner/work/shield/shield/tests/Language/AbstractTranslationTestCase.php:259

https://github.com/codeigniter4/shield/actions/runs/9068936216/job/24922062972?pr=1117

kenjis
kenjis reviewed May 14, 2024
View reviewed changes
@kenjis
Copy link
Member
kenjis commented May 14, 2024

Also, please sign all commits.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#signing
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#gpg-signing-old-commits

@datamweb datamweb removed the tests needed Pull requests that need tests label May 18, 2024
@datamweb
Copy link
Collaborator
datamweb commented May 18, 2024

@mieszkou thank you!
The last thing to do is to sign all the commits.

Screenshot 2024-05-18 191831

It is explained gpg-signing-old-commits.

As a faster alternative, you can still securely sign commits without the -S option in git commit. See Set Default Signing.

mieszkou and others added 17 commits May 18, 2024 18:07
@mieszkou
add polish translation
0d9e280
@mieszkou
fix
25239f4
@mieszkou @michalsn
Update src/Language/pl/Auth.php
d547e19 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
600711d 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
fb670be 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
78e830a 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
e09dfcd 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
0a722bc 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
116ed73 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
dc3ae65 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
8b32b39 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
b9c8464 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
ef2caf6 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
995a484 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @ B622 michalsn
Update src/Language/pl/Auth.php
a8434ee 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
3d6bdae 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
605658c 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
mieszkou and others added 9 commits May 18, 2024 18:07
@mieszkou @michalsn
Update src/Language/pl/Auth.php
2fea628 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
8c5f2f1 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
cce68f3 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Update src/Language/pl/Auth.php
35d9c2a 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou @michalsn
Apply suggestions from code review
95d5f7f 
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@mieszkou
tests
95fb8ad
@mieszkou
fix: phpunit-lang.yml
2c4078c
@mieszkou 55A6
fix test
4f5322b
@mieszkou
re-fix phpunit fix
9beb1c1
@datamweb datamweb removed the GPG-Signing needed Pull requests that need GPG-Signing label May 19, 2024
@datamweb datamweb requested a review from michalsn May 19, 2024 00:09
kenjis
kenjis approved these changes May 19, 2024
View reviewed changes
Copy link
Member
@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

michalsn
michalsn approved these changes May 19, 2024
View reviewed changes
Copy link
Member
@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@datamweb datamweb merged commit b942c47 into codeigniter4:develop May 19, 2024
@datamweb
Copy link
Collaborator
datamweb commented May 19, 2024

@mieszkou Welcome to Shield Contributors!
Merged.

@kenjis kenjis mentioned this pull request Jun 13, 2024
Merged
5 tasks
@kenjis kenjis mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees

No one assigned

Labels

lang Languages file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mieszkou @datamweb @kenjis @michalsn
0