8000 Added GitHub Actions CI detection. by nmoinvaz · Pull Request #265 · codecov/codecov-python · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Added GitHub Actions CI detection.#265

Merged
thomasrockhu merged 1 commit intocodecov:masterfrom
nmoinvaz:improvements/github-actions
Jun 8, 2020
Merged

Added GitHub Actions CI detection.#265
thomasrockhu merged 1 commit intocodecov:masterfrom
nmoinvaz:improvements/github-actions

Conversation

@nmoinvaz
Copy link
Copy Markdown
Contributor
@nmoinvaz nmoinvaz commented May 27, 2020

I initially had to do this before GitHub Actions was public. I now updated/copied from the bash uploader.

@codecov
Copy link
Copy Markdown
codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #265   +/-   ##
=====================================
  Coverage      88%    88%           
=====================================
  Files           2      2           
  Lines           9      9           
=====================================
  Hits            8      8           
  Misses          1      1

@hoefling
Copy link
Copy Markdown
hoefling commented May 28, 2020

@nmoinvaz shouldn't this obsolete the necessity of passing the token explicitly? When trying the tokenless upload, I still get the message Error: Missing repository upload token (example job, install codecov from this PR). No issue when using the bash uploader, though (example job using bash uploader).

@nmoinvaz
Copy link
Copy Markdown
Contributor Author
nmoinvaz commented May 28, 2020

I'm not sure how tokenless works. This PR only gets the environment variable values when running on GitHub Actions environment and uses them in the upload to Codecov.

@alecgerona
Copy link
Copy Markdown
alecgerona commented Jun 5, 2020

Any updates on this? This is especially useful for running tests inside tox since it has issues running the bash uploader. It can't detect if it's running from Github Actions.

@thomasrockhu
Copy link
Copy Markdown
Contributor
thomasrockhu commented Jun 6, 2020

Thanks @nmoinvaz on this, could we get some tests for this new behavior?

@thomasrockhu thomasrockhu self-requested a review June 6, 2020 18:23
@nmoinvaz
Copy link
Copy Markdown
Contributor Author
nmoinvaz commented Jun 7, 2020

Done.

@thomasrockhu thomasrockhu merged commit 48a5613 into codecov:master Jun 8, 2020
thomasrockhu
thomasrockhu reviewed Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor
@thomasrockhu thomasrockhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@nmoinvaz nmoinvaz mentioned this pull request Jun 14, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@thomasrockhu thomasrockhu thomasrockhu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmoinvaz @hoefling @alecgerona @thomasrockhu
0