Use process.stdout.write instead of console.log and increase batch size #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`console.log` does some extra work to construct the output, and because it's already a string, we can save some memory by using `process.stdout.write`. See this issue for more information: nodejs/node#1741 (comment) This is an attempt to remedy the OOM issues when rendering all the issues. Increasing the batch size will also help by reducing the number of GCs.
|
I think it's hilarious our LGTM. Do you know if |
|
@wfleming it used to be 100, which caused issues (I forget exactly what they were though). |
|
In terms of flushing the buffer, I was wrong about what was going on. See the linked github issue for what is actually happening. |
gdiggs
added a commit
that referenced
this pull request
Jan 12, 2016
Use process.stdout.write instead of console.log and increase batch size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.logdoes some extra work to construct the output, and becauseit's already a string, we can save some memory by using
process.stdout.write. See this issue for more information:nodejs/node#1741 (comment)
This is an attempt to remedy the OOM issues when rendering all the
issues. Increasing the batch size will also help by reducing the number
of GCs.
@codeclimate/review