8000 Deprecation free by andrew-demb · Pull Request #18 · code-tool/jaeger-client-symfony-bridge · GitHub
[go: up one dir, main page]
Skip to content

Deprecation free #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2021
Merged

Deprecation free #18

merged 2 commits into from
Jun 29, 2021

Conversation

andrew-demb
Copy link
Contributor

Resolve deprecations:

  1. The signature of method "Symfony\Component\DependencyInjection\Alias::setDeprecated()" requires 3 arguments (since symfony/dependency-injection 5.1)
  2. "isMasterRequest()" is deprecated, use "isMainRequest()" instead. [HttpFoundation][HttpKernel] Rename master request to main request symfony/symfony#40536 (since symfony/http-kernel 5.3)

@andrew-demb
📦 Avoid deprecation by using compiler pass which is compatible with a…
d6a3536 
…ll supported symfony versions (4/5)

> Since symfony/dependency-injection 5.1: The signature of method "Symfony\Component\DependencyInjection\Alias::setDeprecated()" requires 3 arguments: "string $package, string $version, string $message", not defining them is deprecated
@andrew-demb
📦 Avoid deprecation by using checking method availability
e746361 
> Since symfony/http-kernel 5.3 "isMasterRequest()" is deprecated, use "isMainRequest()" instead.
andrew-demb
andrew-demb commented Jun 3, 2021
View reviewed changes
@allflame allflame merged commit 5cf21a4 into code-tool:3.0.x Jun 29, 2021
@andrew-demb andrew-demb deleted the deprecation-free branch June 29, 2021 09:31
@andrew-demb andrew-demb mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-demb @allflame
0