8000 feat(create-cli): add categories codegen by hanna-skryl · Pull Request #1267 · code-pushup/cli · GitHub
[go: up one dir, main page]
Skip to content

feat(create-cli): add categories codegen#1267

Open
hanna-skryl wants to merge 2 commits intomainfrom
categories-codegen
Open

feat(create-cli): add categories codegen#1267
hanna-skryl wants to merge 2 commits intomainfrom
categories-codegen

Conversation

@hanna-skryl
Copy link
Collaborator
@hanna-skryl hanna-skryl commented Mar 12, 2026

Categories support has been added to the setup wizard's code generation. Plugins can now specify categories in their PluginCodegenResult, which are collected and displayed in the generated configuration. The categories block is skipped when no plugin provides categories, so the existing behavior remains unchanged.

This update is a prerequisite for plugin bindings that need to generate categories along with their plugin configuration.

@hanna-skryl hanna-skryl self-assigned this Mar 12, 2026
@nx-cloud
Copy link
nx-cloud bot commented Mar 12, 2026 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c87fde0

Command Status Duration Result
nx run ci:code-pushup -- merge-diffs --files=/h... ✅ Succeeded 5s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 1m 33s View ↗
nx run-many --targets=code-pushup --parallel=fa... ✅ Succeeded 11m 21s View ↗
nx run-many -t unit-test,int-test ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-13 20:15:25 UTC

@github-actions
Copy link
Contributor
github-actions bot commented Mar 12, 2026 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit af3c069 with previous commit d13cc6e.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 35 🔴 37 ↑ +2.3
Updates 🟡 73 🟡 72 ↓ −0.4
Code coverage 🟢 92 🟢 92 ↑ +0.1
Documentation 🟡 52 🟡 52 ↑ +0.1
Bug prevention 🟡 75 🟡 75 ↓ −0.1
Axe Accessibility 🟡 88 🟡 88 ↓ −0.1
Code style 🟢 100 🟢 100 –
Security 🔴 0 🔴 0 –
Type Safety 🟡 67 🟡 67 –
Miscellaneous 🟡 67 🟡 67 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟢 92 🟢 92 –
👍 3 groups improved, 👎 1 group regressed, 👍 8 audits improved, 👎 2 audits regressed, 15 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 35 🔴 37 ↑ +2.3
JS packages npm outdated dependencies 🟡 73 🟡 72 ↓ −0.4
Code coverage Code coverage metrics 🟢 92 🟢 92 ↑ +0.1
JSDocs coverage Documentation coverage 🟡 52 🟡 52 ↑ +0.1

30 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 740 ms 🟩 Root document took 400 ms ↓ −45.6 %
Lighthouse Speed Index 🟥 6.4 s 🟨 5.7 s ↓ −11.9 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.0 s ↓ −10.2 %
JS packages Outdated npm dev dependencies. 🟨 61 outdated package versions (30 major, 25 minor, 6 patch) 🟨 61 outdated package versions (32 major, 24 minor, 5 patch) +0 %
Lighthouse Time to Interactive 🟥 14.6 s 🟥 13.8 s ↓ −5.7 %
Lighthouse Max Potential First Input Delay 🟥 660 ms 🟥 1,270 ms ↑ +93.6 %
JSDocs coverage Functions coverage 🟥 628 undocumented functions 🟥 632 undocumented functions ↑ +0.6 %
Code coverage Line coverage 🟩 92.6 % 🟩 92.6 % ↑ +0.1 %
Code coverage Branch coverage 🟨 89.1 % 🟨 89.2 % ↑ +0.1 %
Code coverage Function coverage 🟩 94.1 % 🟩 94.1 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,386 KiB 🟩 Total size was 2,399 KiB ↑ +0.5 %
Lighthouse Minimizes main-thread work 🟥 9.1 s 🟥 10.7 s ↑ +17.5 %
Lighthouse Server Backend Latencies 🟩 1,320 ms 🟩 190 ms ↓ −85.6 %
Lighthouse Largest Contentful Paint 🟥 13.8 s 🟥 12.7 s ↓ −7.9 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 322 KiB 🟥 Potential savings of 276 KiB ↓ −49.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −5.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 102 KiB 🟥 Potential savings of 107 KiB ↓ −77.6 %
Lighthouse JavaScript execution time 🟥 2.9 s 🟥 2.7 s ↓ −6.7 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 111 KiB 🟥 Potential savings of 111 KiB ↑ +24 %
Lighthouse Total Blocking Time 🟥 2,090 ms 🟥 2,010 ms ↓ −3.8 %
Lighthouse Network Round Trip Times 🟩 50 ms 🟩 10 ms ↓ −76.9 %
JS packages Vulnerabilities for npm prod dependencies. 🟥 18 vulnerabilities (2 critical, 6 high, 3 moderate, 7 low) 🟥 23 vulnerabilities (2 critical, 7 high, 8 moderate, 6 low) ↑ +27.8 %
Lighthouse Avoids an excessive DOM size 🟥 2,341 elements 🟥 2,340 elements ↓ −0.1 %
Lighthouse Cumulative Layout Shift 🟩 0 🟩 0 ↓ −100 %

653 other audits are unchanged.

@github-actions
Copy link
Contributor
github-actions bot commented Mar 12, 2026 •
edited
Loading

Code PushUp

🥳 Code PushUp report has improved – compared current commit af3c069 with previous commit d13cc6e.

💼 Project create-cli

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category 8000 Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 91 🟢 92 ↑ +0.3
Documentation 🔴 24 🔴 24 ↑ +0.2

4 other categories are unchanged.

👍 2 groups improved, 👍 4 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 91 🟢 92 ↑ +0.3
JSDocs coverage Documentation coverage 🔴 24 🔴 24 ↑ +0.2

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 48 undocumented functions 🟥 50 undocumented functions ↑ +4.2 %
Code coverage Function coverage 🟩 90.9 % 🟩 91.3 % ↑ +0.4 %
Code coverage Line coverage 🟩 94.1 % 🟩 94.3 % ↑ +0.3 %
Code coverage Branch coverage 🟩 91 % 🟩 91.1 % ↑ +0.1 %

439 other audits are unchanged.

💼 Project utils

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 94 🟢 94 ↑ +0.1
Documentation 🟡 61 🟡 61 ↑ +0.1

4 other categories are unchanged.

👍 2 groups improved, 👍 4 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1
JSDocs coverage Documentation coverage 🟡 61 🟡 61 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDocs coverage Functions coverage 🟥 253 undocumented functions 🟥 255 undocumented functions ↑ +0.8 %
Code coverage Branch coverage 🟩 91.4 % 🟩 91.4 % ↑ +0.1 %
Code coverage Function coverage 🟩 95.4 % 🟩 95.4 % ↑ +0.1 %
Code coverage Line coverage 🟩 97.6 % 🟩 97.6 % ↑ +0.1 %

440 other audits are unchanged.

12 other projects are unchanged.

@hanna-skryl hanna-skryl marked this pull request as ready for review March 12, 2026 18:52
@hanna-skryl hanna-skryl requested a review from matejchalk March 12, 2026 18:52
matejchalk
matejchalk requested changes Mar 13, 2026
View reviewed changes
@pkg-pr-new
Copy link
pkg-pr-new bot commented Mar 13, 2026

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1267

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1267

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1267

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1267

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1267

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1267

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1267

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1267

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1267

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1267

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1267

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1267

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1267

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1267

commit: c87fde0

@hanna-skryl hanna-skryl requested a review from matejchalk March 13, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalk matejchalk Awaiting requested review from matejchalk

Requested changes must be addressed to merge this pull request.

Assignees

@hanna-skryl hanna-skryl

Labels

🧩 create-cli 🔬 testing writing tests 🧩 utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanna-skryl @matejchalk
0