8000 Add WAF Log nonterminatingmatchingrules field to Glue table. by sureshc · Pull Request #69743 · code-dot-org/code-dot-org · GitHub
[go: up one dir, main page]
Skip to content

Add WAF Log nonterminatingmatchingrules field to Glue table. #69743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Add WAF Log nonterminatingmatchingrules field to Glue table. #69743

wants to merge 1 commit into from

Conversation

@sureshc
8000
Copy link
Contributor
@sureshc sureshc commented Nov 24, 2025

Add the Web Application Firewall (WAF) Web Access Control List (ACL) log field nonterminatingmatchingrules to the Glue table so we can search for HTTP requests that were COUNTed and determine whether those Rules are identifying legitimate malicious requests and that the rate of false positives is low.

Testing story

code-dot-org % export AWS_PROFILE=codeorg-admin
code-dot-org % bundle exec rake stack:data:validate RAILS_ENV=production ADMIN=true
Finished stack:data:environment (less than a minute)
Pending update for stack `DATA-production`:
Modify GlobalWebACLLogsTable [AWS::Glue::Table] Properties Replacement: Conditional (TableInput)
Finished stack:data:validate (less than a minute)

Deployment strategy

code-dot-org % export AWS_PROFILE=codeorg-admin
code-dot-org % bundle exec rake stack:data:start RAILS_ENV=production ADMIN=true

Follow-up work

Privacy

Security

Caching

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc sureshc marked this pull request as ready for review November 24, 2025 00:53
@sureshc sureshc requested a review from a team as a code owner November 24, 2025 00:53
@sureshc
Copy link
Contributor Author
sureshc commented Nov 24, 2025

Deployed

Stack update requested, waiting for provisioning to complete...
.2025-11-24 00:56:02 UTC- GlobalWebACLLogsTable [UPDATE_IN_PROGRESS]
2025-11-24 00:56:03 UTC- GlobalWebACLLogsTable [UPDATE_COMPLETE]
2025-11-24 00:56:04 UTC- DATA-production [UPDATE_COMPLETE_CLEANUP_IN_PROGRESS]
2025-11-24 00:56:02 UTC- GlobalWebACLLogsTable [UPDATE_IN_PROGRESS]
2025-11-24 00:56:03 UTC- GlobalWebACLLogsTable [UPDATE_COMPLETE]
2025-11-24 00:56:04 UTC- DATA-production [UPDATE_COMPLETE_CLEANUP_IN_PROGRESS]

Stack update complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sureshc
0