[pull] main from expo:main#668
Merged
Conversation
# Why To expose the entry/exit animation configuration to the JS side. **Note** that with the animations affecting layout (`expand`/`shrink`), it's better to leave the layout to compose. If `Host` with `matchesContent` is used, then the layout will jump, as there are no synchronous events in react native android yet. # How This PR adds an API similar to SwiftUI approach: - builder pattern for both entry and exit animations - passes them down as an array of configuration objects # Test Plan https://github.com/user-attachments/assets/112cf147-6d9e-4ea4-962b-4d30719f59aa # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Update EAS CLI reference for 18.3.0. # How <!-- How did you build this feature or fix this bug and why? --> - Run `yarn run eas-cli-sync` to sync to the latest changes and update the CLI version - Add normalization to parse broken external links in the script. (External Apple developers documentation link was broken after the sync). # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> See preview. # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
…3865) # Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> Fix ENG-18812 # How - Update `expo-android.diff` to use `ExpoReactHostFactory.getDefaultReactHost()` instead of the old `ReactNativeHostWrapper` pattern, matching what `install-expo-modules@latest` produces for RN 0.83. - Update `expo-ios.diff` to reflect RN 0.83's new `AppDelegate.swift` structure: `ExpoAppDelegate`, `ExpoReactNativeFactory`, `ExpoReactNativeFactoryDelegate`, and `internal import Expo`. - Bump version reference in `installing-expo-modules.mdx` from RN 0.81 to RN 0.83. - Update the Expo template GitHub link from `sdk-54` to `sdk-55`. # Test Plan - Create a fresh RN 0.83 project with `npx @react-native-community/cli@latest init myapp --version 0.83.0`. - Apply the diffs shown on the Install Expo modules page manually and verify the project builds on both Android and iOS. - Compare the manual diff output against running `npx install-expo-modules@latest` on a clean RN 0.83 project to confirm they match. For docs changes, see Preview: https://pr-43865.expo-docs.pages.dev/bare/installing-expo-modules/ # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Closes #42423 # How Bump react-native-maps to 1.27.2 # Test Plan Run NCL locally # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why In order to show content above keyboard # How Expose `imePadding` modifier # Test Plan Bare expo https://github.com/user-attachments/assets/eab7b239-bd06-4cbd-a387-6dd1354046e4 # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why We want expo go to own it's own implementation of the dev menu. This makes it easier to make changes without impacting expo-dev-menu # How Copy over dev menus ui and integrate with the kernel # Test Plan Expo go
# Why `currentBridge` is always nil on RN 0.84 so we need to remove references to it # How We can get everything we need from the manifest and the react host on the kernel # Test Plan Expo go
# Why Align with latest React Native core version # How - Update gradle to 9.3.1 + fix `org.jetbrains:annotations` versions mismatch - Update package versions - `react-native 0.85-rc.0 -> 0.85-rc.1` - `@react-native/normalize-colors 0.85-rc.0 -> 0.85-rc.1` - `@react-native/babel-preset 0.85-rc.0 -> 0.85-rc.1` - `@react-native/dev-middleware 0.85-rc.0 -> 0.85-rc.1` # Test Plan - Bare Expo - Minimal tester # Checklist - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
# Why Brings the same server discovery from expo-dev-launcher to expo go # Test Plan Expo go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )