8000 Improve error reporting when custom error handler is used by SimonFrings · Pull Request #47 · clue/stream-filter · GitHub
[go: up one dir, main page]
Skip to content

Improve error reporting when custom error handler is used #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

Improve error reporting when custom error handler is used #47

merged 1 commit into from
Jun 1, 2022

Conversation

SimonFrings
Copy link
Contributor

See reactphp/socket#290
Builds on top of 20bd61a and #37.

clue
clue requested changes May 26, 2022
View reviewed changes
Copy link
Owner
@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this! 👍

@clue clue added this to the v1.7.0 milestone May 26, 2022
@SimonFrings SimonFrings force-pushed the error-handler branch 10 times, most recently from 0664505 to 9aaf854 Compare June 1, 2022 11:55
clue
clue approved these changes Jun 1, 2022
View reviewed changes
Copy link
Owner
@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 8f64659 into clue:1.x Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
bug new feature
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonFrings @clue
0