Use global loop accessor #109
Conversation
There was a problem hiding this comment.
@WyriHaximus Thanks for bringing this up, this definitely helps reviewing reactphp/event-loop#226 and seeing its real-world impact on existing code!
Removing the LoopInterface from our interfaces would make this a BC break that would break most existing consumers of this project. It's my understanding this could be an option in the longer run, but in the short term I have a strong preference towards #110 which uses the global loop without introducing any BC breaks.
For the reference, the build errors are unrelated to the changes in this PR. I'll look into an update to address this asap 👍
|
I believe this has been answered and will close this for now (see #110 for preferred alternative), please feel free to report back otherwise 👍 |
No description provided.