[RFC] Update test environment and work around segfault with Xdebug 3.5.0-dev #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree on reporting this issue. Will wait with merging this PR til we get back an answer. |
This was referenced Mar 6, 2025
Reported upstream and confirmed fixed already shivammathur/setup-php#923 (comment) I'll close this one and apply the minimal changeset to apply the CI/CD update in follow-up PR #277 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to work around a segfault with Xdebug 3.5.0-dev. Right now, this causes an unrelated build error for all builds on Windows with PHP 8.2+ (see also clue/reactphp-redis#173).
I wonder how widespread this problem would be exactly, as I don't see anything special that this project would execute (except perhaps for Fibers as of #117?). In either case, we should probably report this upstream to Xdebug and/or shivammathur/setup-php.
Builds on top of #267, #221 and clue/reactphp-redis#173