8000 Foggy - MVP by daodesigner · Pull Request #27 · clrfund/clrfund-deployer · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foggy - MVP #27

Merged
merged 7 commits into from
Mar 31, 2021
Merged

Foggy - MVP #27

merged 7 commits into from
Mar 31, 2021

Conversation

daodesigner
Copy link
Contributor
@daodesigner daodesigner commented Mar 6, 2021

Goals:

  • Deploy and configure a new instance of clr.fund from a single location (e.g. web GUI)

  • Registries are deployed and managed externally and only linked up within the GUI

  • Coordinator is managed externally and only linked up with the GUI

  • Funding rounds are initiated and managed from the command line

50 story points

@adamstallard
Copy link

These sound like great goals.

Copy link
Member
@spengrah spengrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Added a couple comments for what I suspect are just typos

README.md Outdated
```
<br/>

`useCancelCurrentRound(contractAddress)`: Cancel current round, must be called by owner and current round must be finalzed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "current round must NOT be finalized"?

README.md Outdated
```
<br/>

`useTransferMatchingFunds(contractAddress)`: Transfer funds from matching pool to current funding round and finalize it. Can only be called by number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can only be called by "owner", not "number" i assume? ;)

@daodesigner
Copy link
Contributor Author
daodesigner commented Mar 9, 2021

Going to leave this PR open for the sprint and merge at the end of the *sprint. Will request another review in a few days. Also where can I look up the contract address for the Funding Factories we have?

@daodesigner daodesigner added 28 34 and removed 28 labels Mar 9, 2021
@spengrah
Copy link
Member
spengrah commented Mar 11, 2021

Also where can I look up the contract address for the Funding Factories we have?

I don't think there's actually a good place for this. I believe this is the current Funding Round Factory in use, but its hard to tell since its not verified: 0x0dA71825182944234F45755989a8C96Ac1343E07

Edit: the contracts for each round are posted to the clrfund forum. Here's the post for the most recent round (4) -- https://forum.clr.fund/t/xdai-funding-round-04/82

Also, @daodesigner sorry again for the delayed response! Github notifications are killing me

@daodesigner daodesigner changed the title WIP - Foggy WIP - Foggy Sprint 1 Mar 19, 2021
@daodesigner daodesigner added 50 and removed 34 labels Mar 19, 2021
@daodesigner daodesigner changed the title WIP - Foggy Sprint 1 WIP - Foggy Sprint 1/2 Mar 20, 2021
@daodesigner daodesigner changed the title WIP - Foggy Sprint 1/2 WIP - Foggy Sprint 2/2 Mar 24, 2021
@daodesigner
Copy link
Contributor Author

Figma Prototypes and UX Audit/Visual Attention Study

CLRDEP CLRDEP_VAS_Original
CLRDEP CLRDEP_VAS_VisualSequence
CLRDEP CLRDEP_VAS_Regions
CLRDEP CLRDEP_VAS_Heatmap

This was unlinked from issues Mar 31, 2021
@daodesigner daodesigner changed the title WIP - Foggy Sprint 2/2 Foggy - MVP Mar 31, 2021
@daodesigner
Copy link
Contributor Author

Cutting over first running build, focusing remainder of the sprint on proxy factory contracts and then implementing Figma designs and squashing bugs if there's time.

@daodesigner daodesigner merged commit 2a067d2 into main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set User Registry in Funding Round Factory Set Coordinator in Funding Round Factory Transfer ownership of MACI factory to Funding Round Factory Arbitrary EVM network connection xDAI network connection
Set token in Funding Round Factory Set Recipient Registry in Funding Round Factory Set signup and voting durations in Funding Round Factory < 4389 a href="https://github.com/clrfund/clrfund-deployer/issues/29" data-hydro-click="{"event_type":"issue_cross_references.click","payload":{"reference_location":"PULL_REQUEST_SIDEBAR","user_id":null,"issue_id":836879540,"pull_request_id":585975472,"originating_url":"https://github.com/clrfund/clrfund-deployer/pull/27"}}" data-hydro-click-hmac="324cfe0e11458d892d7001ee98bbb9235ab56b6e973ce687a0a215dab1868ae2" data-hovercard-type="issue" data-hovercard-url="/clrfund/clrfund-deployer/issues/29/hovercard" data-view-component="true" class="Truncate-text Link--primary markdown-title text-bold"> metamask support, basic network support, actually sends txs UX Figma Mockups and Sprint Planning
3 participants
0