-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foggy - MVP #27
Foggy - MVP #27
Conversation
These sound like great goals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Added a couple comments for what I suspect are just typos
README.md
Outdated
``` | ||
<br/> | ||
|
||
`useCancelCurrentRound(contractAddress)`: Cancel current round, must be called by owner and current round must be finalzed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "current round must NOT be finalized"?
README.md
Outdated
``` | ||
<br/> | ||
|
||
`useTransferMatchingFunds(contractAddress)`: Transfer funds from matching pool to current funding round and finalize it. Can only be called by number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can only be called by "owner", not "number" i assume? ;)
Going to leave this PR open for the sprint and merge at the end of the *sprint. Will request another review in a few days. Also where can I look up the contract address for the Funding Factories we have? |
I don't think there's actually a good place for this. I believe this is the current Funding Round Factory in use, but its hard to tell since its not verified: 0x0dA71825182944234F45755989a8C96Ac1343E07 Edit: the contracts for each round are posted to the clrfund forum. Here's the post for the most recent round (4) -- https://forum.clr.fund/t/xdai-funding-round-04/82 Also, @daodesigner sorry again for the delayed response! Github notifications are killing me |
Cutting over first running build, focusing remainder of the sprint on proxy factory contracts and then implementing Figma designs and squashing bugs if there's time. |
Goals:
Deploy and configure a new instance of clr.fund from a single location (e.g. web GUI)
Registries are deployed and managed externally and only linked up within the GUI
Coordinator is managed externally and only linked up with the GUI
Funding rounds are initiated and managed from the command line
50 story points