8000 feat: `disable_rollback` and `template_body` Inputs by milldr · Pull Request #38 · cloudposse/terraform-aws-cloudformation-stack · GitHub
[go: up one dir, main page]
Skip to content

feat: disable_rollback and template_body Inputs #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 26, 2025
Merged

feat: disable_rollback and template_body Inputs #38

merged 12 commits into from
Sep 26, 2025

Conversation

milldr
Copy link
Member
@milldr milldr commented Sep 26, 2025 •
edited
Loading

what

  • Add disable_rollback variable for stack creation
  • Add template_body variable
  • Fixed tests

why

8000
  • Support new inputs
  • The cloudformation template we were using as a test fixture does not exist anymore, so instead we can use a copy inline.

references

@milldr milldr requested review from a team as code owners September 26, 2025 14:42
@milldr milldr added the minor New features that do not break anything label Sep 26, 2025
@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

aknysh
aknysh previously approved these changes Sep 26, 2025
View reviewed changes
@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr milldr changed the title feat: disable_rollback Input feat: disable_rollback and template_body Inputs Sep 26, 2025
@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr
Copy link
Member Author
milldr commented Sep 26, 2025

/terratest

@milldr milldr enabled auto-merge (squash) September 26, 2025 16:12
@milldr milldr merged commit ce3265a into main Sep 26, 2025
15 checks passed
@milldr milldr deleted the feat/disable-rollback branch September 26, 2025 16:32
@github-actions GitHub Actions
Copy link

These changes were released in v0.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aknysh aknysh aknysh approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees

No one assigned

Labels

minor New features that do not break anything

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milldr @aknysh
0