feat: Parameterized DOCKER_METADATA_PR_HEAD_SHA to allow for PR-HEAD tagging #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Github Action uses merge commits during PR events for the (referenced via the `github.sha` variable). Some users find this challenging, since the merge commit contains code from the target branch, which is troublesome for long-running branches, merge-conflicts, and a hotfix workflow for deploying one-off containers. This allows users to configure docker metadata-action to compute the SHA tags appropriately. Unfortunately the metadata-action does not compute based on a checkout action of the code, so we have to tell it to use the correct event SHA explicitly with this environment variable. See https://github.com/docker/metadata-action#environment-variables
milldr
reviewed
Jul 12, 2023
Co-authored-by: Dan Miller <miller0daniel@gmail.com>
|
@pk-nb Till that moment you can use the workaround: - name: Build
id: build
uses: cloudposse/github-action-docker-build-push@main
with:
registry: registry.hub.docker.com
organization: "${{ github.event.repository.owner.login }}"
repository: "${{ github.event.repository.name }}"
login: "${{ secrets.DOCKERHUB_USERNAME }}"
password: "${{ secrets.DOCKERHUB_PASSWORD }}"
platforms: linux/amd64,linux/arm64
env:
DOCKER_METADATA_PR_HEAD_SHA=true |
|
@pk-nb Thanks for your contribution. https://github.com/cloudposse/github-action-docker-build-push/releases/tag/1.13.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has
2D67
been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
docker-metadataaction will use the PR merge commit for the docker SHA tags (referenced via thegithub.shavariable).github.event.pull_request.head.shainstead.checkoutaction in their own workflows to usegithub.event.pull_request.head.sha)See https://github.com/docker/metadata-action#environment-variables for documentation.
why
mainbranch code in it for hotfixes (with a manual release workflow that we use)truecheck so the default offalsewill work as expected.