8000 Expose buildx provenance by Sytten · Pull Request #38 · cloudposse/github-action-docker-build-push · GitHub
[go: up one dir, main page]

Skip to content

Expose buildx provenance #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

Sytten
Copy link
Contributor
@Sytten Sytten commented May 31, 2023

what

  • Expose provenance buildx parameter

why

  • Deploy to lambda

references

@@ -33,6 +33,9 @@ inputs:
description: "List of target platforms for build (e.g. linux/amd64,linux/arm64,linux/riscv64,linux/ppc64le,linux/s390x,etc)"
required: false
default: 'linux/amd64'
provenance:
description: "Generate provenance attestation for the build"
required: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required: false
needs a default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the default changes based on the buildx version, but I can add one

Copy link
Contributor 8000 Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author
@Sytten Sytten May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a default is literarily a breaking change in this case I think because public repos will get the private repo mode=min,inline-only=true. I also see that build-args is not required and has no default

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that will fail linter when we add it. In this case it means the default is just ""

@goruha goruha changed the base branch from main to buildx-provenance June 1, 2023 15:33
@goruha goruha merged commit 71770d9 into cloudposse:buildx-provenance Jun 1, 2023
goruha added a commit that referenced this pull request Jun 1, 2023
Expose buildx provenance (#38)

Co-authored-by: Émile Fugulin <code@efugulin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose provenance for buildx
3 participants
0