Expose buildx provenance #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-lobur
reviewed
May 31, 2023
| @@ -33,6 +33,9 @@ inputs: | |||
| description: "List of target platforms for build (e.g. linux/amd64,linux/arm64,linux/riscv64,linux/ppc64le,linux/s390x,etc)" | |||
| required: false | |||
| default: 'linux/amd64' | |||
| provenance: | |||
| description: "Generate provenance attestation for the build" | |||
| required: false | |||
There was a problem hiding this comment.
The problem is that the default changes based on the buildx version, but I can add one
There was a problem hiding this comment.
There was a problem hiding this comment.
Adding a default is literarily a breaking change in this case I think because public repos will get the private repo mode=min,inline-only=true. I also see that build-args is not required and has no default
There was a problem hiding this comment.
Yeah that will fail linter when we add it. In this case it means the default is just ""
max-lobur
approved these changes
May 31, 2023
goruha
added a commit
that referenced
this pull request
Jun 1, 2023
Expose buildx provenance (#38) Co-authored-by: Émile Fugulin <code@efugulin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
references