Fix missing Poster functionality and Autoplay for cld-video #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
This PR fixes two different problems in the Vue SDK:
What does this PR address?
Are tests included?
What was changed
An entire section dealing with poster calculation was missing, some refactoring was done to discover the missing bits, and a test was added to ensure the fixed implementation works.
The fix involves calculating child transformations in the poster calculations, and fixing the format types
For the Autoplay, after some experimentation, it was discovered that when
AutoplayandMutedare not explicitly set on the Element, autoplay functionality does not work properly.This fix was teste don a stand-alone test-app to ensure it does solve the autplay issue.
Please ignore all the ./dist files in your. review.