8000 Move Vue to PeerDepdency instead of Dependency by patrick-tolosa · Pull Request #102 · cloudinary/cloudinary-vue · GitHub
[go: up one dir, main page]
Skip to content

Move Vue to PeerDepdency instead of Dependency #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

Move Vue to PeerDepdency instead of Dependency #102

merged 1 commit into from
Sep 3, 2020

Conversation

patrick-tolosa
Copy link
Contributor
  • Add an accurate devDependency for development
  • Add a ^2.0.0 peerDependency
  • Remove inaccurate support for Vue3

Brief Summary of Changes

This PR addresses #101
Also, during testing, it was discovered that vue3 support is inaccurate, and in fact this library does not work with Vue3,
as such the documentation was adjusted

What does this PR address?

Are tests included?

  • Yes
  • No (This was manually tested)

@patrick-tolosa
Move Vue to PeerDepdency instead of Dependency
2625db4 
- Add an accurate devDependency for development
- Add a ^2.0.0 peerDependency
- Remove innacurate support for Vue3
@patrick-tolosa patrick-tolosa merged commit 35e17ea into master Sep 3, 2020
@patrick-tolosa patrick-tolosa deleted the feature/move-vue-to-peer-dependency branch September 3, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strausr strausr strausr approved these changes

@asisayag2 asisayag2 asisayag2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-tolosa @strausr @asisayag2
0