Updated flurry (Cache Performance Improvement)#248
Closed
NathanielPrescott wants to merge 2 commits intocloudflare:mainfrom
NathanielPrescott:flurry-update
Closed
Updated flurry (Cache Performance Improvement)#248NathanielPrescott wants to merge 2 commits intocloudflare:mainfrom NathanielPrescott:flurry-update
NathanielPrescott wants to merge 2 commits intocloudflare:mainfrom
NathanielPrescott:flurry-update
Conversation
Contributor
Author
|
Any updates on this one? |
Collaborator
|
Thanks for contributing, this was included in our latest sync! |
escoffier
pushed a commit
to escoffier/pingora
that referenced
this pull request
Sep 6, 2024
--- Specified quick_cache version because older version was being loaded on build Includes-commit: 3f5419e Includes-commit: de83f0a Replicated-from: cloudflare#248
xxargonaut
added a commit
to xxargonaut/pingora
that referenced
this pull request
Feb 19, 2025
--- Specified quick_cache version because older version was being loaded on build Includes-commit: 3f5419e92d64769534e3ab6f497ee938f07616fa Includes-commit: de83f0a6122aa9be637faf4e7ed0c3f73d20a78c Replicated-from: cloudflare/pingora#248
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Pingora became open sourced I've been experimenting and learning as much as I can, especially from TinyUFO. While messing with TinyUFO I found a comment about not using Rust version 1.71 even though the MSVR is 1.72. I've upgraded the flurry and quick_cache versions and then ran the TinyUFO benches. The results are run using v0.5.1 for each crate, on a arch linux system with an 8 core CPU. I'm not sure how this change would look on a more relevant server setup, but I would be interested in seeing the results.
The bench_hit_ratio and bench_memory look the same or similar enough between both version.
bench_perf (Ops per Second):
As you can see there is a significant increase in performance for TinyUFO, though quick_cache has an absurd increase. Let me know if you have any questions or concerns with updating these crates.