8000 Improve public API type annotations & fix unit test type errors by h4l · Pull Request #248 · cloudevents/sdk-python · GitHub
[go: up one dir, main page]
Skip to content

Improve public API type annotations & fix unit test type errors #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 23, 2025
Merged

Improve public API type annotations & fix unit test type errors #248

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e9b6301
chore: improve typing of functions returning AnyCloudEvent
h4l Mar 17, 2025
eacac4f
chore: type v1.Event chainable Set*() methods
h4l Mar 17, 2025
f81c902
chore: fix type errors in tests
h4l Mar 17, 2025
b70ef0a
chore: allow non-dict headers types in from_http()
h4l Mar 25, 2025
66aa64b
build: run mypy via tox
h4l Mar 25, 2025
a3291f5
build(ci): run mypy in CI alongside linting
h4l Mar 25, 2025
029d122
chore: fix minor mypy type complaint in samples
h4l Mar 25, 2025
f611c29
feat: use Mapping, not Dict for input arguments
h4l Mar 25, 2025
dccd3cf
chore: fix tests on py3.8
h4l Mar 25, 2025
130cdfa
feat: support new model_validate_json() kwargs
h4l Apr 1, 2025
c144dbb
chore: accept Mapping as well as SupportsDuplicateItems
h4l May 21, 2025
ed68011
chore: constrain deps to maintain py 3.8 support
h4l May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix minor mypy type complaint in samples 
Signed-off-by: Hal Blackburn <hwtb2@cam.ac.uk>
  • Loading branch information
@h4l
h4l committed Mar 25, 2025
commit 029d122efa01262e0dbf1db061b2818eb48f1abb
4 changes: 2 additions & 2 deletions samples/http-image-cloudevents/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
image_bytes = resp.content


def send_binary_cloud_event(url: str):
def send_binary_cloud_event(url: str) -> None:
# Create cloudevent
attributes = {
"type": "com.example.string",
Expand All @@ -42,7 +42,7 @@ def send_binary_cloud_event(url: str):
print(f"Sent {event['id']} of type {event['type']}")


def send_structured_cloud_event(url: str):
def send_structured_cloud_event(url: str) -> None:
# Create cloudevent
attributes = {
"type": "com.example.base64",
Expand Down
0