8000 Changed JSON schema validator's options to remove warning: "$ref: key… by Kirusi · Pull Request #10 · cloudevents/sdk-javascript · GitHub
[go: up one dir, main page]
Skip to content

Changed JSON schema validator's options to remove warning: "$ref: key… #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2019
Merged

Changed JSON schema validator's options to remove warning: "$ref: key… #10

merged 1 commit into from
Apr 22, 2019

Conversation

Kirusi
Copy link
Contributor
@Kirusi Kirusi commented Apr 17, 2019

A fix for issue #7: $ref: keywords ignored in schema at path "#"

@Kirusi
Changed JSON schema validator's options to remove warning: "$ref: key…
4cde675 
…words ignored in schema at path "#" "

Signed-off-by: Kirusi Msafiri<kirusi.msafiri@gmail.com>
@fabiojose
Copy link
Contributor

@Kirusi can you check the failed checks?

@Kirusi
Copy link
Contributor Author
Kirusi commented Apr 18, 2019

@fabiojose

  1. Travis build. All tests pass under all versions of node, but script fails to send coverage. The error is "Error: "Token is required". Please address this in your build script.
  2. DCO check is a false alarm, as I signed off in commit # 4cde675

@fabiojose
Copy link
Contributor

@Kirusi, oh boy! we had this problem with another pr.

Please do this:
Remove the script: npm run coverage for now
Please remove the command above in .travis.yml and push again.

We are checking this issue with coverage.

@Kirusi
Copy link
Contributor Author
Kirusi commented Apr 22, 2019

@fabiojose Please don't take offense, but I consider the requested changes as unproductive. It's work for the sake of bureaucracy, just to satisfy the broken build process. You can merge the request as is, or copy-paste the one line change and commit from your side where the build process works.

@fabiojose fabiojose merged commit dcc92cd into cloudevents:develop Apr 22, 2019
@fabiojose
Copy link
Contributor

@Kirusi, I agree with you!

Done.

@fabiojose fabiojose mentioned this pull request Apr 22, 2019
Closed
@csantanapr csantanapr mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kirusi @fabiojose
0