8000 [ISSUE #521]Remove unused import by mxsm · Pull Request #522 · cloudevents/sdk-java · GitHub
[go: up one dir, main page]
Skip to content

[ISSUE #521]Remove unused import #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[ISSUE #521]Remove unused import #522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a24e824
[ISSUE #521]Remove unused import
mxsm Feb 18, 2023
cf9d08f
polish code style
mxsm Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[ISSUE #521]Remove unused import 
Signed-off-by: mxsm <ljbmxsm@gmail.com>
  • Loading branch information
@mxsm
mxsm committed Feb 20, 2023
commit a24e824ab264add4cc0c2c8165f8f21a60eb58ba
2 changes: 1 addition & 1 deletion ...es/restful-ws-quarkus/src/test/java/io/cloudevents/examples/quarkus/UserResourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import io.quarkus.test.junit.QuarkusTest;
import org.junit.jupiter.api.Test;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this empty line? Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi I will remove it and resbumit this pr later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

You can alternatively accept this suggestion

import static io.restassured.RestAssured.given;
import static org.hamcrest.CoreMatchers.is;

@QuarkusTest
public class UserResourceTest {
Expand Down
2 changes: 0 additions & 2 deletions ...s/restful-ws-spring/src/test/java/io/cloudevents/http/restful/ws/spring/JerseyConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@
import org.glassfish.jersey.server.ResourceConfig;
import org.springframework.context.annotation.Configuration;

import javax.ws.rs.ApplicationPath;

@Configuration
public class JerseyConfig extends ResourceConfig {
public JerseyConfig() {
Expand Down
3 changes: 0 additions & 3 deletions ...ertx/src/test/java/io/cloudevents/http/vertx/VertxHttpClientRequestMessageWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@
import io.vertx.core.MultiMap;
import io.vertx.core.Vertx;
import io.vertx.core.buffer.Buffer;
import io.vertx.core.http.HttpClient;
import io.vertx.core.http.HttpClientRequest;
import io.vertx.core.http.HttpMethod;
import io.vertx.ext.web.client.WebClient;
import io.vertx.junit5.Checkpoint;
import io.vertx.junit5.VertxExtension;
Expand Down
2 changes: 0 additions & 2 deletions ...rtx/src/test/java/io/cloudevents/http/vertx/VertxHttpServerResponseMessageWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,11 @@

import io.cloudevents.Cl 5CBB oudEvent;
import io.cloudevents.SpecVersion;
import io.cloudevents.core.message.impl.GenericStructuredMessageReader;
import io.cloudevents.core.mock.CSVFormat;
import io.cloudevents.types.Time;
import io.vertx.core.MultiMap;
import io.vertx.core.Vertx;
import io.vertx.core.buffer.Buffer;
import io.vertx.core.http.HttpClient;
import io.vertx.ext.web.client.WebClient;
import io.vertx.junit5.Checkpoint;
import io.vertx.junit5.VertxExtension;
Expand Down
0