docs: add contributor, maintainer and pr guides #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a simple contributors guide, and an in depth set of guidelines for creating, submitting and updating pull requests. There is also a short set of suggestions for repository maintainers in a third document. Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
slinkydeveloper
approved these changes
May 11, 2020
<
8000
div class="blankslate-container">
Signed-off-by: Lance Ball <lball@redhat.com>
|
@slinkydeveloper thanks for the quick review! I've updated the PR with your suggestions. |
<
8000
div class="d-flex flex-md-row flex-column">
Signed-off-by: Lance Ball <lball@redhat.com>
slinkydeveloper
approved these changes
May 11, 2020
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a simple contributors guide, and an in depth set of guidelines
for creating, submitting and updating pull requests. There is also a short set
of suggestions for repository maintainers in a third document.
In an effort to better organize and manage the javascript SDK, I have done this for that repository here. There has been some pushback however because this is not common across all of the SDKs in the organization. I have slightly modified my pull request on the javascript SDK and submitted it here for wider discussion (even though I am not a committer on this project).
The most notable difference between this and what I have suggested for the javascript SDK is that we use the conventional commits fspecification in order to manage the CHANGELOG.md and I thought this might be too big of a change/suggestion for the Go SDK.
Looking forward to the discussion.
Signed-off-by: Lance Ball lball@redhat.com