8000 Added a correct return type for Responses::createResponse by zlodes · Pull Request #536 · cloudcreativity/laravel-json-api · GitHub
[go: up one dir, main page]
Skip to content

Added a correct return type for Responses::createResponse #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2020
Merged

Added a correct return type for Responses::createResponse #536

merged 2 commits into from
Aug 13, 2020

Conversation

zlodes
Copy link
Contributor
@zlodes zlodes commented Jul 29, 2020

To reduce warnings in IDE and static analyze tools (e.g. Psalm).

@lindyhopchris
Copy link
Member

Hey! Thanks for submitting this. Definitely happy to merge... I wasn't sure though, does it ever return a ResponseFactory? I think that's unlikely - the return type is probably always Response.

@zlodes
Copy link
Contributor Author
zlodes commented Aug 13, 2020

@lindyhopchris Yes. Only Response. Fixed.

@lindyhopchris lindyhopchris merged commit e1fc46a into cloudcreativity:develop Aug 13, 2020
@lindyhopchris
Copy link
Member

Thanks for updating!

@zlodes zlodes deleted the fix-phpdoc branch August 13, 2020 12:54
5BF3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlodes @lindyhopchris
0