8000 adding the models location namespace to the config file by Mina-R-Meshriky · Pull Request #479 · cloudcreativity/laravel-json-api · GitHub
[go: up one dir, main page]
Skip to content

adding the models location namespace to the config f 8000 ile #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2020
Merged

adding the models location namespace to the config file #479

merged 2 commits into from
Feb 8, 2020

Conversation

Mina-R-Meshriky
Copy link
Contributor

adding the models location namespace as a variable to the api config file
adding the "ModelNamespace\Model" in the phpDoc of the eloquent schema

@Mina-R-Meshriky
adding the models location namespace to the config file
ebd4511 
adding the namespace and model name in the phpDoc of the eloquent schema
lindyhopchris
lindyhopchris requested changes Feb 3, 2020
View reviewed changes
Copy link
Member
@lindyhopchris lindyhopchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this PR - it's a fantastic addition and a great idea! Just some comments to address before merging.

@lindyhopchris lindyhopchris mentioned this pull request Feb 3, 2020
Closed
zlodes
zlodes suggested changes Feb 5, 2020
View reviewed changes
lindyhopchris
lindyhopchris approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member
@lindyhopchris lindyhopchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments, will merge this now.

@lindyhopchris lindyhopchris merged commit 67330eb into cloudcreativity:develop Feb 8, 2020
6C83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zlodes zlodes zlodes requested changes

@lindyhopchris lindyhopchris lindyhopchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mina-R-Meshriky @zlodes @lindyhopchris
0