[Bugfix] Fix wrong returned methods in validators #370
Conversation
I think the methods used in return statement were inverted between delete and create requests.
|
I'm not sure about this. But i can confirm that when i make a POST request (with one field that not respect his own rules) to create a new resource with a custom validator, the response throws an error with title "Not deletable" instead of "Unprocessable Entity". |
|
Hmmm... I don't get this either, because the tests relating to this are passing. It does indeed look wrong though so think I need to figure out how to reproduce the failure in the tests before merging your fix. |
|
Ah ok I get it now, the |
|
In fact this method is present in the doc to use custom decoding. https://laravel-json-api.readthedocs.io/en/latest/features/media-types/#custom-decoding You're welcome. By the way, i really like what you're done in this package. Edit: you were too fast :) |
|
Yes, present in the docs is what I meant as a helper method! I've added a test now that failed before your PR, and passes now your PR has been merged. Glad you are finding the package useful! |
The methods used in return statement were inverted between delete and create requests.