Fix incorrect integer conversion from int to uint16 in port forwarder#12831
Merged
williammartin merged 2 commits intotrunkfrom Mar 4, 2026
Merged
Fix incorrect integer conversion from int to uint16 in port forwarder#12831williammartin merged 2 commits intotrunkfrom
williammartin merged 2 commits intotrunkfrom
Conversation
Use the existing convertIntToUint16 helper with bounds checking instead of a raw uint16() cast on remotePort in UpdatePortVisibility. This prevents potential integer overflow when the port value exceeds the uint16 range (0-65535). Fixes code scanning alert #137 (go/incorrect-integer-conversion). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a potential integer overflow (go/incorrect-integer-conversion, CWE-190/681) in UpdatePortVisibility by replacing a direct uint16(remotePort) cast with a call to the existing convertIntToUint16 helper, which performs bounds checking and returns an error if the value is out of range (0–65535).
Changes:
- Replaces the raw
uint16(remotePort)cast inUpdatePortVisibilitywith a safeconvertIntToUint16call and error handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
williammartin
approved these changes
Mar 4, 2026
babakks
approved these changes
Mar 4, 2026
Member
|
I'm merging this without codespaces review since it seems obvious. |
babakks
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the existing
convertIntToUint16helper with bounds checking instead of a rawuint16()cast onremotePortinUpdatePortVisibility. This prevents potential integer overflow when the port value exceeds the uint16 range (0–65535).Fixes https://github.com/cli/cli/security/code-scanning/137 (
go/incorrect-integer-conversion, CWE-190, CWE-681).