8000 fix: error when --remote flag used with repo argument by majiayu000 · Pull Request #12375 · cli/cli · GitHub
[go: up one dir, main page]
Skip to content

fix: error when --remote flag used with repo argument #12375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BagToad merged 2 commits into from
Mar 2, 2026
Merged

fix: error when --remote flag used with repo argument #12375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f0044f
fix: error when --remote flag used with repo argument
majiayu000 Dec 26, 2025
1c36686
Merge branch 'trunk' into 2722-fix-fork-remote-flag
BagToad Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/cmd/repo/fork/fork.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ func NewCmdFork(f *cmdutil.Factory, runF func(*ForkOptions) error) *cobra.Comman
opts.Rename = true // Any existing 'origin' will be renamed to upstream
}

if opts.Repository != "" && cmd.Flags().Changed("remote") {
return cmdutil.FlagErrorf("the `--remote` flag is unsupported when a repository argument is provided")
}

if promptOk {
// We can prompt for these if they were not specified.
opts.PromptClone = !cmd.Flags().Changed("clone")
Expand Down
6 changes: 6 additions & 0 deletions pkg/cmd/repo/fork/fork_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ func TestNewCmdFork(t *testing.T) {
Rename: false,
},
},
{
name: "remote with repo argument",
cli: "foo/bar --remote",
wantErr: true,
errMsg: "the `--remote` flag is unsupported when a repository argument is provided",
},
}

for _, tt := range tests {
Expand Down
0